Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CSS rules #8547

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Remove unused CSS rules #8547

merged 1 commit into from
Jun 11, 2020

Conversation

AlbertHilb
Copy link
Contributor

Fixes #8537.

@AlbertHilb AlbertHilb added pkg:codemirror tag:CSS For general CSS related issues and pecadilloes labels Jun 11, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added the tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. label Jun 11, 2020
blink1073
blink1073 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 modified the milestones: 2.2, 3.0 Jun 11, 2020
@blink1073 blink1073 merged commit 6f529d1 into jupyterlab:master Jun 11, 2020
@AlbertHilb AlbertHilb deleted the CodeMirrorEditor-static branch June 15, 2020 10:55
@saulshanabrook saulshanabrook mentioned this pull request Jun 24, 2020
Closed
@saulshanabrook saulshanabrook modified the milestones: 3.0, 2.2 Jun 24, 2020
saulshanabrook pushed a commit that referenced this pull request Jun 25, 2020
@saulshanabrook
Merge pull request #8547 from AlbertHilb/CodeMirrorEditor-static
b4f75ea 
Remove unused CSS rules
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review.
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

jp-CodeMirrorEditor-staticHTML element class
3 participants
@AlbertHilb @blink1073 @saulshanabrook